On Apr 27, 2008, at 11:22 AM, Johannes Schindelin wrote:
On Sun, 27 Apr 2008, Brian Gernhardt wrote:
Should this construct go into CodingStyle? I seem to have to write
patches like this every month or so.
Yes, probably. I am very sorry, I really should have reviewed those
patches better (I know that ":" in expr is better than "match",
"tac" is
something to be avoided, and "wc -l" can output whitespace). It did
not
help that I hated the fact that that series changed the original
design
without even understanding it.
Eh, not everyone's perfect. I would have used `rev` instead of `tac`
and still been wrong for Solaris. But it seems that the `wc -l`
whitespace issue seems to hit nearly everyone at some point, so I
thought it would be a good candidate for CodingStyle.
Personally, I'd love to have the time to review all the patches to
catch these issues while still on the list instead of waiting until
they hit next and I tried to compile it. But I don't always notice,
have time, or care myself.
~~ Brian
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
