On Tue, Apr 01, 2008 at 09:02:15PM -0700, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > So may I put it back? :) > > I agree that it makes sense to send the output to standard error for > consistency. Many existing hooks called from scripted versions of tools > seem to contaminate the standard output, though. That would be a good > post 1.5.5 clean-up, perhaps. Ok, I will put it back. > > Also, is the other parts of the series looks correct? > > I do not think we would want empty templates/hooks--pre-gc-auto file. I did it this way as we have such an empty post-commit hook as well, so I added it for consistency. Though it's true that for example post-applypatch doesn't have such an empty hook under templates either. What is your opinion here? Possibilities I see: 1) Just don't add such an empty template for pre-auto-gc. 2) Remove post-commit as well. 3) Add missing empty templates, like post-applypatch (maybe there are more, I haven't did a complete research). I've did the rest of the modifications locally as you suggested just I don't want to spam the list with the series before the empty templates question is not clear to me :) Thanks
Attachment:
pgpdgAbpn9Wlz.pgp
Description: PGP signature
