Re: [PATCH 0/4] add pre-auto-gc hook for git-gc --auto (try2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 01, 2008 at 04:18:01PM -0700, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> > - removed unnecessary stdout_to_stderr from builtin-gc.c::run_hook()
> 
> Wait, a, minute, please.  Not so fast.  I did not say "I think this is
> wrong, please fix it".
> 
> I only asked why it is so.
> 
> Care to explain why it was thought to be necessary, and why you now think
> it is unnecessary?

Ok, let me explain. I think it would be logical to put it to stderr, as
the other gc --auto messages are there, as well. See the fprintf() in
cmd_gc().

Though, I don't think it's that important, so I thought if you think
it's unnecessary, I would not argue for it.

So may I put it back? :)

Also, is the other parts of the series looks correct?

Thanks

Attachment: pgpFjKYxcAjLJ.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux