Nicolas Pitre <nico@xxxxxxx> writes: >> > diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c >> > index f504cff..4c2ed70 100644 >> > --- a/builtin-pack-objects.c >> > +++ b/builtin-pack-objects.c >> > @@ -17,6 +17,8 @@ >> > #include "progress.h" >> > #include "refs.h" >> > >> > +#include <utime.h> >> > + >> >> Hmmm. Shouldn't this go to git-compat-util.h? > > Maybe... if you say so. > > The whole header file arrangement logic is somewhat escaping my mind, so > I simply decided to do the same as in test-chmtime.c. The general idea is to isolate the place system headers are included at, so that we have to worry about the inclusion and feature-macro definition order at only one place (see for example the hack about _ALL_SOURCE to work around AIX 5.3, yuck). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
