Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>> Yuck; approxidate() returns ulong. Can subtracting a ulong from another
>> ever go negative?
>>
>> Besides, because there is no guarantee of the order of evaluation between
>> these two approxidate() calls, you may get +1 or -1 on the second boundary.
>>
>> I think the reason why you did not catch it in your test is because your
>> tests are half complete; they test only what you wanted to catch
>> (misconfigured case) and do not test the other half (properly working
>> case).
>
> Yes, probably. Of course, comparing a difference to 0 is absolutely
> moronic.
>
> I should have written
>
> approxidate(value) >= approxidate("now"))
>
> in the first place.
Eh, sorry, but why?
> So, could you tell me, please, if I should resend the patch with your
> --prune documentation, or without?
I like Nico's suggestion to put that "historical notes" in RelNotes, so
the documentation part is fine as is.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
