Re: [PATCH v2] gc: call "prune --expire 2.weeks.ago" by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 12 Mar 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> 
> > Okay, so I just remove the !approxidate() check.  Then, "gc.pruneExpire = 
> > never" should work as you expect it to.
> 
> Huh?  date.c::special[] has "never" defined for this exact reason.

Oops.  I thought that approxidate() returns 0 on error, but apparently 
this is not so.  Instead, it returns "now"!

So first of all, my patch is incorrect, and second: invalid dates cannot 
be caught reliably.

Darn.

Ciao,
Dscho "who'll think about a way around that"


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux