On Sun, Mar 09, 2008 at 10:17:18AM +0000, Junio C Hamano wrote: > Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > > >> You made the loop a subshell but I think you can redirect into the while > >> loop without an extra "cat" process. > > > > Well probably yeah, I could use an exec -- < series or an alike trick > > for sure. > > It seems many people forget that it is perfectly fine to redirect into > while loop itself, like > > while read foo bar > do > do a lot of stuff > done <input-file Oh right, well, I assume you already squashed that on top of my patch :) > Ok, somehow in an earlier patch to quiltimport I picked up an incorrect > notion that they could contain a blank, but then that's fine. Well, maybe they could, but quilt doesn't get it right. > Will queue, but I am very well into my merge binge for tonight (and it > hasn't finished even though it is past 3 AM, sheesh), so it will be in the > next round. That's obviously fine by me, thanks :) -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpFQetomUR5U.pgp
Description: PGP signature
