Re: [PATCH] git-quiltimport: better parser to grok "enhanced" series files.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 09, 2008 at 03:39:21AM +0000, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@xxxxxxxxxx> writes:
> 
> >   I'd even argue that it's maint material btw :)
> 
> I don't know.

Well not groking the -pNNN makes it useless for me in its current form, 80% of
the quilt series I use have them (and right now it says: I cannot apply patch
'foo-bar.patch -p1').

> You made the loop a subshell but I think you can redirect into the while
> loop without an extra "cat" process.

Well probably yeah, I could use an exec -- < series or an alike trick
for sure.

> Can a patch name contain $IFS whitespace characters?

  I tested and quilt says that:

$ quilt new a\ b.patch
Patch a is now on top

And when I quilt refresh it, it creates a patch named 'a'.  (and yes, I thought
of this and tested it prior to sending the patch).

> If so, this patch would regress them.  Otherwise it looks fine.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@xxxxxxxxxx
OOO                                                http://www.madism.org

Attachment: pgpiVGcYBstLK.pgp
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux