Junio C Hamano schrieb:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>> On Tue, 4 Mar 2008, David Bremner wrote:
>>
>>> It looks like line 435 of builtin-commit.c disables stdin for hooks
>>> (with the disclaimer that I first looked at the git source ten minutes
>>> ago).
>>>
>>> hook.no_stdin = 1
>>>
>>> I'm not sure if this was by design, but just so you know, this breaks
>>> people's hooks. In particular the default metastore pre-commit hook no
>>> longer works. I didn't find anything relevant in the docs [1].
>> Pardon my ignorance, but what business has metastore reading stdin? There
>> should be nothing coming in, so the change you mentioned should be
>> correct, and your hook relies on something it should not rely on.
>
> It is not metastore. It is an interactive hook that reads from the user
> who is sitting on the terminal and invoked the git-commit program.
Are you saying stdin should not be directed to /dev/null, or that an
interactive hook is required to do
exec < /dev/tty || { echo 2>&1 "not interactive"; exit 1; }
before it reads from stdin?
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
