Re: [PATCH 1/3] git-pack-objects: Automatically pack annotated tags if object was packed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 3 Mar 2008, Shawn O. Pearce wrote:

> Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote:
> > On Mon, 3 Mar 2008, Shawn O. Pearce wrote:
> > 
> > > +	if (auto_tags && nr_result)
> > > +		for_each_ref(add_ref_tag, NULL);
> > 
> > There's for_each_tag_ref() that does the path-based filter internally, in 
> > a possibly more efficient way, and avoids open-coding the test for whether 
> > this is a tag sort of ref.
> 
> Yea, I know about that call, but I didn't use it because I was
> trying to use peel_ref() for its optimized peeled caching in
> a packed-refs file.

Ah, okay. I hadn't noticed that it didn't pass on the full name. Using 
for_each_ref() is better, then, I think.

	-Daniel
*This .sig left intentionally blank*
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux