On Mon, 3 Mar 2008, Shawn O. Pearce wrote: > + if (auto_tags && nr_result) > + for_each_ref(add_ref_tag, NULL); There's for_each_tag_ref() that does the path-based filter internally, in a possibly more efficient way, and avoids open-coding the test for whether this is a tag sort of ref. Aside from that, it looks good to me. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html