On Sun, Mar 2, 2008 at 10:38 PM, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
> Carlos Rica, Sun, Mar 02, 2008 19:40:09 +0100:
>
> > On Sun, Mar 2, 2008 at 4:55 PM, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
> > >
> > > "static const struct option options[] = {"
> >
> > The other files using parse_options have only "static", or nothing.
>
> Well, they all miss something. Besides all nice things about static
> syntax checking, the compiler (GCC) can optimize string constants to
> use the same data (not that it is interesting in this particular
> case).
>
>
> > To make "options" static, then reset_type and quiet should be
> > static too, otherwise it cannot compile (in my system).
>
> Of course. Is it a problem for user-interface level code?
The only problem could come from reusing this code to calling
many times to a cmd_reset function in the future. Then, I would
prefer not to worry about previous values in the variables by
using only automatic variables in the function.
Anyway, "const" is nice, since the options struct doesn't change.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
