Hi,
On Thu, 28 Feb 2008, Paolo Bonzini wrote:
> Johannes Schindelin wrote:
>
> > On Wed, 27 Feb 2008, Johannes Sixt wrote:
> >
> > > +int gettimeofday(struct timeval *tv, void *tz)
> > > +{
> > > + return 0;
> > > +}
> >
> > Should it not return -1, for failure? (I know, I know, probably a few
> > programs do not work, then, but it is not correct that it succeeded.)
>
> FWIW, this is overwritten by later patches in the series anyway.
Yes, I know that. But the whole point of having a nice patch series is to
have proper revisions, and IMO returning 0 here is not correct.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
