Re: [PATCH 6/9] Completely move out worktree setup from setup_git_directory_gently()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 27 Feb 2008, Nguyễn Thái Ngọc Duy wrote:

> This was impossible earlier because git_dir can be relative. Now that
> git_dir is absolute, I see no reason for worktree setup inside
> setup_git_directory_gently().

I do see it, though.  Why make the users work harder?  If you want to get 
the git directory, chances are that you want to work with a worktree, too.

And you really cannot properly separate worktree detection from git 
directory detection: in most of the cases, you will find them at the 
_same_ time (if .git/ is the git directory, the working directory is .).

So I am mildly negative on the thrust of your patch series.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux