On Thu, Feb 28, 2008 at 10:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:>> "Nguyen Thai Ngoc Duy" <pclouds@xxxxxxxxx> writes:>> > On Thu, Feb 28, 2008 at 9:17 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:> >> Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:> >>> >> > - prefix = setup_git_directory_gently(&nongit);> >> > - init_revisions(&rev, prefix);> >> > + setup_git_directory_gently(&nongit);> >> > + init_revisions(&rev, NULL);> >>> >>> >>> >> > @@ -233,19 +233,20 @@ int cmd_diff(int argc, const char **argv, const char *prefix)> >> > ...> >>> >> > - init_revisions(&rev, prefix);> >> > + init_revisions(&rev, NULL);> >>> >> Hmm. How is the effect of this change compensated later to give> >> proper prefix value to rev.diffopt.prefix?> >>> >> > I assume you meant rev.prefix? rev.prefix is set right before> > setup_revisions(). (grr.. I think I left an redundant> > rev.diffopt.skip_stat_unmatch assignment)>> I did mean rev.diffopt.prefix that is initialized by the last> four lines in init_revisions() from the value of prefix you> pass. Um.. I missed commit "diff --relative". Thanks for noticing.-- Duy���m�ka����zwm���˛��m���ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
