On Mon, 18 Feb 2008, Daniel Barkalow wrote: > On Mon, 18 Feb 2008, Johannes Schindelin wrote: > > > In addition to Junio's concern that add_user_info() really wants to be > > called pp_add_user_info(), I cannot help myself but suspect that > > pp_write_email_headers() -- which called for a new name, too -- also wants > > to live in pretty.c. > > Good idea, although I think "pp" is a verb about putting the result in the > provided strbuf, so "pp_user_info()" and "pp_email_headers()". > > It's different, currently, in that it actually outputs the headers, rather > than putting them in a buffer and uses struct rev_info. I'll need to work > on this some more. It's pretty firmly tied to a different style from the pp_* functions, so I think I'll make it log_write_email_headers() for this series. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
