On Mon, 18 Feb 2008, Johannes Schindelin wrote: > Hi, > > On Sun, 17 Feb 2008, Daniel Barkalow wrote: > > > diff --git a/commit.h b/commit.h > > index 10e2b5d..42b4825 100644 > > --- a/commit.h > > +++ b/commit.h > > @@ -71,6 +71,21 @@ extern void pretty_print_commit(enum cmit_fmt fmt, const struct commit*, > > int abbrev, const char *subject, > > const char *after_subject, enum date_mode, > > int non_ascii_present); > > +void add_user_info(const char *what, enum cmit_fmt fmt, struct strbuf *sb, > > + const char *line, enum date_mode dmode, > > + const char *encoding); > > +void pp_title_line(enum cmit_fmt fmt, > > + const char **msg_p, > > + struct strbuf *sb, > > + const char *subject, > > + const char *after_subject, > > + const char *encoding, > > + int plain_non_ascii); > > +void pp_remainder(enum cmit_fmt fmt, > > + const char **msg_p, > > + struct strbuf *sb, > > + int indent); > > + > > In addition to Junio's concern that add_user_info() really wants to be > called pp_add_user_info(), I cannot help myself but suspect that > pp_write_email_headers() -- which called for a new name, too -- also wants > to live in pretty.c. Good idea, although I think "pp" is a verb about putting the result in the provided strbuf, so "pp_user_info()" and "pp_email_headers()". It's different, currently, in that it actually outputs the headers, rather than putting them in a buffer and uses struct rev_info. I'll need to work on this some more. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
