Hi,
On Fri, 8 Feb 2008, Junio C Hamano wrote:
> "H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes:
>
> > HP-UX allows directories to be opened with fopen (path, "r"), which
> > will cause some translations that expect to read files, read dirs
> > instead. This patch makes sure the two fopen () calls in remote.c
> > only open the file if it is a file.
>
> > +static FILE *open_file(char *full_path)
> > +{
> > + struct stat st_buf;
> > + if (stat(full_path, &st_buf) || !S_ISREG(st_buf.st_mode))
> > + return NULL;
> > + return (fopen(full_path, "r"));
> > +}
>
> Can we make this a platform specific "compat" hack?
You mean something like
#ifdef FOPEN_OPENS_DIRECTORIES
inline static FILE *fopen_compat(const char *path, const char *mode)
{
struct stat st_buf;
if (stat(path, &st_buf) || !S_ISREG(st_buf.st_mode))
return NULL;
return (fopen(path, mode));
}
#define fopen fopen_compat
#endif
in git-compat-util.h, right?
Yeah, I can see that, even if I think the overhead would not be _that_
crucial. But it is a nice way of fixing _all_ fopen() calls at the same
time.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
