"H.Merijn Brand" <h.m.brand@xxxxxxxxx> writes: > HP-UX allows directories to be opened with fopen (path, "r"), which > will cause some translations that expect to read files, read dirs > instead. This patch makes sure the two fopen () calls in remote.c > only open the file if it is a file. > +static FILE *open_file(char *full_path) > +{ > + struct stat st_buf; > + if (stat(full_path, &st_buf) || !S_ISREG(st_buf.st_mode)) > + return NULL; > + return (fopen(full_path, "r")); > +} Can we make this a platform specific "compat" hack? It is not fair to force stat() overhead to ports on platforms that fails fopen() on directories, as I doubt we would ever want from directory using fopen() anyway. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html