Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > On Tue, 5 Feb 2008, Johannes Schindelin wrote: > ... >> BTW after the whole series (was too lazy to check the individual >> patches), I count one instance in builtin-checkout.c and two in diff-lib.c >> where unpack_trees()' return value is not checked. Is this intended? > > ..., but it's probably best to check and > exit anyway, if only in the conversion commit. (If we remove the check > afterward, there will be a change in the history that documents that we > don't need to check) I think that is a sensible thing to do. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
