Hi, On Mon, 4 Feb 2008, Daniel Barkalow wrote: > Return an error from unpack_trees() instead of calling die(), and exit > with an error in read-tree and builtin-commit. Technically, there is still a possibility that an xcalloc() fails with a die(), but I agree that it is a good change. BTW after the whole series (was too lazy to check the individual patches), I count one instance in builtin-checkout.c and two in diff-lib.c where unpack_trees()' return value is not checked. Is this intended? Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
