Re: [EGIT PATCH Series] Cleanups and javadocs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tisdagen den 5 februari 2008 skrev Roger C. Soares:
> 
> Robin Rosenberg escreveu:
> > Here is a number of small enhancements that reduce the number of warnings
> > displayed and raises the standard on comments. We now get javadoc comments
> > on all public and protected methods which hopefully will make it slighly
> > easier to get on the train for those interested in helping out with Egit/Jgit.
> >
> > Disabling the else-warning is probably fairly uncontroversial. Disabling some
> > warning about boxing/unboxing of integers might be as might be requiring
> > javadoc comments.
> >
> >   
> Hi Robin,
> 
> [2, 3, 5 and 6] - looks fine to me.
Thanks for looking.

> [1] - What about something like "nothing to be done here" and/or 
> "implementing interface method"?
"Empty" is a marker that the block is *intentionally* empty, which
is the point here.

> [4] - Some typos:
Thanks

-- robin

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux