Hi,
On Sat, 19 Jan 2008, Grégoire Barbier wrote:
> Since HTTP/302 is not handled in the git code calling curl, URLs without
> leading / used to lead to frozen git-fetch or git-push with no error message.
JFYI these lines are a little bit too long; I would like to see them
unwrapped with a 4-space indent on a 80-column display.
I am not sure how easily Junio can fix them.
> @@ -51,6 +52,12 @@ int cmd_http_fetch(int argc, const char **argv, const char *prefix)
> commits = 1;
> }
> url = argv[arg];
> + if (url && url[strlen(url)-1] != '/') {
> + rewritten_url = malloc(strlen(url)+2);
> + strcpy(rewritten_url, url);
> + strcat(rewritten_url, "/");
> + url = rewritten_url;
> + }
>
> walker = get_http_walker(url);
> walker->get_tree = get_tree;
Please use strbuf, like so:
struct strbuf rewritten_url = STRBUF_INIT;
...
url = argv[arg];
if (url && url[strlen(url)-1] != '/') {
strbuf_addstr(&rewritten_url, url);
strbuf_addch(&rewritten_url, '/');
url = rewritten_url.buf;
}
...
strbuf_release(&rewritten_url);
BTW it seems you indented using spaces, but we like the indentation as
tabs in git.git.
Other than that, I like your patch!
Thanks,
Dscho
