Hi, On Fri, 18 Jan 2008, Lars Hjemli wrote: > On Jan 18, 2008 12:09 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Lars Hjemli" <hjemli@xxxxxxxxx> writes: > > > > > Hmm, isn't a nonfunctional libgit considered breakage? Without > > > something like this patch it is no longer possible to use > > > write_tar_archive()/write_zip_archive() in libgit.a. > > > > Sorry, but libgit.a is not part of what we deliver. We do not support > > linking random stuff against libgit.a. We never did. It is not a > > "library". > > I kind of expected this reply, and I know libgit isn't supposed to be a > stable API aginst git internals, but it still feels like a regression: > cgit has been linking against libgit for over a year now (initial > snapshot support added feb 8, 2007), and git-1.5.4 looks like the first > git release which cgit cannot use. So you did something that is unsupported, and now it breaks for you. I'd almost say: you should have expected that. HOWEVER, this makes you the perfect guy to actually do something about libification (which has been on my mind for some time, with the prospect of GitCheetah), and therefore you deserve a little help, IMHO. > > The code movement you did _should_ not hurt so it may be a fine > > material for post 1.5.4, but I haven't carefully compared what other > > change might have accidentally snuck in that patch, and I would rather > > not have to during the rc cycle. I have. The 80 lines that were removed are _exactly_ the 80 lines that were added (prepended with some #includes). Like Lars said, the prototype of the only non-static function, sha1_file_to_archive(), was in archive.h, which is included from builtin-archive.c (where the big hunk was moved from), so there is no possibility of a breakage there. It is no _functional_ change, but if Lars _uses_ the function in cgit, I'd say it would be a "courtesy fix" before 1.5.4. Mind you, I would not propose to make libgit.a fully functional as a standalone library before 1.5.4. But Lars contributed a lot, and did a very good job of collecting git patches back in October. Therefore I think that he deserves a little extra attention, even if it does not fix a bug in git proper. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
