Junio C Hamano wrote: > Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > >> Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> >> --- >> >> >> Shouldn't we be doing this? I think if quiet is set, >> then a failed rename will go undetected since we >> won't enter print_summary to have lookup_commit fail. > > But then it's a bit too late, isn't it? We already have > successfully made the commit and updated the HEAD to point at > it. Ok, so the commit has been made, but the index (since the rename failed), is out of sync? > We would need to tell the user that the index is not where > it is when we detect the error, though. The new index we are trying to rename will be deleted. Are you saying we should warn the user that the index is now out of sync? Or prevent the deletion of the updated index? or just ignore this case which I now see as very unlikely to occur? -brandon - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
