Re: [PATCH v2] Do not show "diff --git" metainfo with --no-prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 16 Jan 2008, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
> 
> > Having had time to think about it for a while, I think that the 
> > --no-prefix still can make sense with --git.  For example, if I want 
> > to submit a gitk patch, but only have git.git (and consequently, made 
> > the fix in that repository), I could use "git diff --no-prefix" to 
> > make it easier for Paul, no?
> 
> No, what you are talking about is a need of negative prefix, which you 
> did not implement in that no/src/dst-prefix patch.

I'm probably missing something, but wouldn't a "diff --git gitk-git/gitk 
gitk-git/gitk" instead of "diff --git a/gitk-git/gitk b/gitk-git/gitk" in 
mbox format be directly grokkable by git-am?

> Using --no-prefix is a _hack_ that may happen to work only when
> the subtree-merged project is one level down.

Yep.  But my point was more to show that it is still a valid git diff.  
With all the niceties that come with it, like "rename from", "rename to".  
So "--no-prefix" is not that good a reason to strip the "--git" away.

Probably I missed something, though.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux