On Wed, 16 Jan 2008, Junio C Hamano wrote:
Brandon Casey <casey@xxxxxxxxxxxxxxx> writes:
My patch does this, though I understand it may take some time to review.
I left the lk->fd unmodified when close() failed in case the caller
would like to include it in an error message.
But that would bring us back to the same double-close issue,
wouldn't it?
Yes it would. Although I knew it would happen, I was disregarding
_that_ double close case for some reason.
You're right, your's and Linus's version is better.
-brandon
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html