On Wed, 16 Jan 2008, Junio C Hamano wrote:
> +
> +void close_lock_file(struct lock_file *lk)
> +{
> + close(lk->fd);
> + lk->fd = -1;
> +}
Since one of the main purposes of closing would be the error testing of
writes that haven't made it out yet on filesystems like NFS that do
open-close cache serialization, I'd suggest doing this as
int close_lock_file(struct lock_file *lk)
{
int fd = lk->fd;
lk->df = -1;
return close(fd);
}
to give the return code.
Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
