On Tue, 18 Dec 2007 01:47:53 -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Andreas Ericsson <ae@xxxxxx> writes: > > > Junio C Hamano wrote: > >> > >> Besides, isn't _HPUX_SOURCE a feature-test macro? Feature test macros > >> are for the application to define, and for the implementation (iow, the > >> header files) to find out what set of names the application wants to > >> see. You are making the application examine the symbol to see what > >> implementation it is on, which feels backwards to me. > > > > > > #if defined(hpux) || defined(_hpux) || defined(__hpux) > > > > should work ok, although as you say, trying > > > > #if _POSIX_VERSION < 200112 > > # include <non-POSIX.1-2001 headers> > > #else > > # include <sys/select.h> > > #endif > > > > would probably be more suitable. > > I cannot take credit for having said that (I didn't), but it sounds like > a sensible thing to compare _POSIX_VERSION with 200112L. For previous > SUS, <sys/time.h> would have defined select(2), but that header file is > already included anyway. > > Merijn, discarding the earlier patch I did to configure it out for > HP-UX, does the following patch based on Andreas's idea work for you? Probably not: HP-UX 10.20, 11.00, 11.11, 11.23/PA, and 11.23/IPF all have: /usr/include 103 > grep -r POSIX_VERSION * sys/unistd.h:# define _POSIX_VERSION _POSIX1_VERSION_88 sys/unistd.h:# define _POSIX_VERSION _POSIX1_VERSION_90 sys/unistd.h:# define _POSIX_VERSION _POSIX1_VERSION_93 sys/unistd.h:# define _SC_1_VERSION_88 7 /* _POSIX_VERSION: Date of POSIX.1-1988 */ sys/unistd.h:# define _SC_1_VERSION_90 102 /* _POSIX_VERSION: Date of POSIX.1-1990 */ sys/unistd.h:# define _SC_1_VERSION_93 103 /* _POSIX_VERSION: Date of POSIX.1b-1993 */ sys/unistd.h:# if (_POSIX_VERSION == _POSIX1_VERSION_88) sys/unistd.h:# if (_POSIX_VERSION == _POSIX1_VERSION_90) and the two 11.23 do have select.h > --- > > git-compat-util.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/git-compat-util.h b/git-compat-util.h > index 79eb10e..68a580f 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -68,7 +68,9 @@ > #include <sys/poll.h> > #include <sys/socket.h> > #include <sys/ioctl.h> > +#if _POSIX_VERSION >= 200112L > #include <sys/select.h> > +#endif > #include <assert.h> > #include <regex.h> > #include <netinet/in.h> -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using & porting perl 5.6.2, 5.8.x, 5.10.x on HP-UX 10.20, 11.00, 11.11, & 11.23, SuSE 10.1 & 10.2, AIX 5.2, and Cygwin. http://qa.perl.org http://mirrors.develooper.com/hpux/ http://www.test-smoke.org http://www.goldmark.org/jeff/stupid-disclaimers/ - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
