On Mon, Dec 17, 2007 at 06:05:58PM -0500, Jeff King wrote: > > I wonder if stripping existing "Message-Id:" away just like we strip > > away "Date:" from @xh would be a much saner fix. > > That is definitely wrong if we expect to re-use the in-reply-to and > references headers that already exist (though obviously we could strip > out all three of those headers and re-add our own). > > I don't have a strong opinion. I never use git-send-email myself, but > was just trying to fix a reported bug. Actually, I don't think stripping the message-id is ever the right thing. The user put it in there for some purpose, and "ours not to reason why" (ours but to do and die). IOW, it is not possible for us to know what we are breaking by changing the message-id. It could simply be the reply-to header in the following messages, or it could be the reply-to in some message we have not and will not ever see. Even if we assume git-send-email only ever gets the unmunged output of git-format-patch, we do not necessarily know it has been fed all of the patches during a single run. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
