Jeff King <peff@xxxxxxxx> writes: > Ah. The problem is that git-send-email unconditionally adds a > message-id. Usually git-format-patch doesn't add one, but for obvious > reasons, it must when doing --thread. Here is a fix. > diff --git a/git-send-email.perl b/git-send-email.perl > index 1d6f466..083466a 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -580,7 +580,7 @@ sub send_message > $ccline = "\nCc: $cc"; > } > my $sanitized_sender = sanitize_address($sender); > - make_message_id(); > + make_message_id() unless defined($message_id); Isn't this called inside a loop? If the outgoing message does not originally have "Message-Id:", does the loop correctly reinitialize $message_id to undef, or does this change make everybody reuse the same $message_id over and over again? I have a feeling that --thread to format-patch is a misfeature. Why is it needed if you are feeding the output to send-email? I wonder if stripping existing "Message-Id:" away just like we strip away "Date:" from @xh would be a much saner fix. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
