Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 01, 2007 at 10:41:47PM +0000, Johannes Schindelin wrote:

> Basically, I ran a test case in which the shell script was different from 
> the builtin version, and this was the patch that fixed it for me.
> 
> Maybe it should have been
> 
> 	if (log_tree_commit(&rev, commit))
> 		printf("\n");
> 
> at the end of print_summary() instead.  Can you try if that fixes it for 
> you?

No, it doesn't, unless you meant "if (!log_tree_commit(...". Of course,
I can't get log_tree_commit to return anything but true anyway (either
log_tree_diff shows something, or since we have set always_show_header,
we end up calling show_log).

It would be helpful if you could remember the test case, but perhaps
that is not an option at this point.

-Peff
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux