Re: [PATCH 6/6] builtin-commit: Add newline when showing which commit was created

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 1 Dec 2007, Jeff King wrote:

> On Sun, Nov 11, 2007 at 05:36:52PM +0000, Johannes Schindelin wrote:
> 
> > The function log_tree_commit() does not break the line, so we have to
> > do it ourselves.
> 
> Johannes,
> 
> Can you explain the rationale for this change in more detail?

Basically, I ran a test case in which the shell script was different from 
the builtin version, and this was the patch that fixed it for me.

Maybe it should have been

	if (log_tree_commit(&rev, commit))
		printf("\n");

at the end of print_summary() instead.  Can you try if that fixes it for 
you?

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux