Re: [PATCH v2 0/3] Add a static analysis job to prevent assertions with side effects

Taylor Blau <me@xxxxxxxxxxxx> · Mon, 17 Mar 2025 18:34:10 -0400

On Sun, Mar 16, 2025 at 06:41:59AM +0000, Elijah Newren via GitGitGadget wrote:
> Elijah Newren (3):
>   git-compat-util: introduce BUG_IF_NOT() macro
>   ci: add build checking for side-effects in assert() calls
>   treewide: replace assert() with BUG_IF_NOT() in special cases

Nice, this version looks great to me. I left a couple of notes
throughout, but they range from "could be done later" to idle
commentary. Thanks for working on this, and I'm sorry to have sent you
down such a rabbit hole ;-).

    Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx>

Thanks,
Taylor