On Sun, Mar 16, 2025 at 06:42:02AM +0000, Elijah Newren via GitGitGadget wrote: > When the compiler/linker cannot verify that an assert() invocation is > free of side effects for us (e.g. because the assertion includes some > kind of function call), replace the use of assert() with BUG_IF_NOT(). Nice. I guess since this is split out into its own patch, we wouldn't be able to cleanly run CI on the previous commit, but I think that's fine, since we don't treat CI as being nearly as precious as being able to 'make' anywhere in history. You didn't realign any multi-line assert() statements, but I actually think that's preferable in this case to demonstrate that the patch does not change the behavior of these assertions. Thanks, Taylor
