During Git 2.40 timeframe, we deprecated the "--stdin" option of the "name-rev" command in preference to the "--annotate-stdin" option, and removed the mention of the former from the documentation. Let's prepare for Git 3.0 to stop supporting it. The real motive of these patches is not really about that particular option but make sure we have, with WITH_BREAKING_CHANGES compilation knob, enough support to keep preparing for these changes. The first two patches are preliminary clean-up and enhancement. We lacked documentation on test_lazy_prereq and we did not have a good way to signal a prerequisite that no longer should be used, both of which are remedied. The third patch renames the WITHOUT_BREAKING_CHANGES prerequisite that unfortunately invites double negations easily and changes existing users of it. Then two patches to a test script minimally modernizes it. The last step introduces the real change, guarded by WITH_BREAKING_CHANGES compilation knob. The resulting code is more littered with #if[n]def compared to the previous round but it should be clear which section of the code should go away once we do Git 3.0, which is the whole point of the WITH_BREAKING_CHANGES exercise. Junio C Hamano (6): t: document test_lazy_prereq t: extend test_lazy_prereq t: introduce WITH_BREAKING_CHANGES prerequisite t6120: avoid hiding "git" exit status t6120: further modernize name-rev: remove "--stdin" support Documentation/BreakingChanges.adoc | 6 ++++++ builtin/name-rev.c | 10 +++++++++- t/README | 25 ++++++++++++++++++++++++- t/t5323-pack-redundant.sh | 2 +- t/t5505-remote.sh | 6 +++--- t/t5515-fetch-merge-logic.sh | 2 +- t/t5516-fetch-push.sh | 8 ++++---- t/t6120-describe.sh | 18 +++++++++++++----- t/test-lib-functions.sh | 5 +++++ t/test-lib.sh | 7 ++++++- 10 files changed, 72 insertions(+), 17 deletions(-) -- 2.49.0-rc2-181-g28e223d67e
