Patrick Steinhardt <ps@xxxxxx> writes:
> On Mon, Mar 10, 2025 at 04:16:52PM -0700, Junio C Hamano wrote:
>> diff --git a/builtin/name-rev.c b/builtin/name-rev.c
>> index beac166b5c..3f49138551 100644
>> --- a/builtin/name-rev.c
>> +++ b/builtin/name-rev.c
>> @@ -578,11 +578,13 @@ int cmd_name_rev(int argc,
>> N_("ignore refs matching <pattern>")),
>> OPT_GROUP(""),
>> OPT_BOOL(0, "all", &all, N_("list all commits reachable from all refs")),
>> +#ifndef WITH_BREAKING_CHANGES
>> OPT_BOOL_F(0,
>> "stdin",
>> &transform_stdin,
>> N_("deprecated: use --annotate-stdin instead"),
>> PARSE_OPT_HIDDEN),
>> +#endif /* WITH_BREAKING_CHANGES */
>> OPT_BOOL(0, "annotate-stdin", &annotate_stdin, N_("annotate text from stdin")),
>> OPT_BOOL(0, "undefined", &allow_undefined, N_("allow to print `undefined` names (default)")),
>> OPT_BOOL(0, "always", &always,
>
> I was wondering whether we should also #ifdef `transform_stdin` and its
> single user to more closely reflect what we would have once the feature
> is fully removed.
Absolutely. That's a great point.
Thanks.
