Elijah Newren <newren@xxxxxxxxx> writes: > On Mon, Feb 24, 2025 at 6:28 AM Christian Couder > <christian.couder@xxxxxxxxx> wrote: > [...snip...] >> diff --git a/Documentation/git-fast-export.adoc b/Documentation/git-fast-export.adoc >> index 1b19f17b78..8750dd150b 100644 >> --- a/Documentation/git-fast-export.adoc >> +++ b/Documentation/git-fast-export.adoc >> @@ -43,6 +43,17 @@ they will be exported, but you will see a warning. 'verbatim' and >> transformation affecting tags will be performed, or if you do not >> care that the resulting tag will have an invalid signature. >> >> +--signed-commits=(verbatim|warn-verbatim|warn-strip|strip|abort):: >> + Specify how to handle signed commits. Behaves exactly as >> + '--signed-tags', but for commits. > > Should this also explicitly call out that the default is abort? Yes, > I know that... Thanks. We all tend to assume that readers know more than they actually are reasonably expected to know. I would have of course expected that any sensible designer would pick 'abort' as the default, but I didn't know what we actually chose without looking at the code ;-) It would make sense to spell it out. Thanks.
