Junio C Hamano <gitster@xxxxxxxxx> writes: > Toon Claes <toon@xxxxxxxxx> writes: > >> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >> >>> The `fixup_pack_header_footer()` function uses the global >>> `the_hash_algo` variable to access the repository's hash function. To >>> avoid global variable usage, pass the hash function from the layers >>> above. >> >> I'm probably being overly pedantic here, so feel free to ignore me. But >> you say "pass the hash function", technically that's not correct, you're >> passing down the struct that defines several properties of the hashing >> algorithm. This includes the hash function, but also other properties >> like the hex size. By using "pass the hash function" in the commit >> messages (and not only this commit message) it sounds to me like you're >> changing the type of the object that desribes the "hash algo". But >> again, feel free to ignore this comment. > > I think the phrasing in the title that uses hash_algo (instead of > "hash function") is fine, so we can use "pass a hash_algo from the > layers above" in the body, perhaps? This is a good suggestion, I'll amend! Thanks both.
Attachment:
signature.asc
Description: PGP signature
