"Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > Changes since v2: > > * Readability improvement to the first patch, which fixes object name > resolution with refs containing a curly brace > * Fixed the second patch for cases like OBJ-COUNT-gHASH~13 and added a > couple test cases for that. Also, extended the commit message a bit to > discuss the cases brought up on the list. > > For the second patch, if folks want some open source examples where it could > be triggered, I found two examples: > > * lore.git: git cat-file -t master:random/path/major-gaffed > * git.git: git cat-file -t super-invalid~///\\.....@.lock-gfd0bba94e > > Elijah Newren (2): > object-name: fix resolution of object names containing curly braces > object-name: be more strict in parsing describe-like output > > object-name.c | 63 ++++++++++++++++++++++++++++++++++++++++++--- > t/t1006-cat-file.sh | 31 +++++++++++++++++++++- > t/t6120-describe.sh | 24 +++++++++++++++++ > 3 files changed, 113 insertions(+), 5 deletions(-) > Although ... > + Note that we'd prefer duplicating the special logic for "@^" characters > + here, because if get_oid_basic() or interpret_nth_prior_checkout() or ... I suspect that you meant "we'd prefer not duplicating" here, both patches look very good to me. Thanks, will replace.
