On Tue, Jan 07, 2025 at 08:23:34AM -0800, Junio C Hamano wrote: > > We do need to use "grep -s" for the case that the glob does not expand > > (i.e., there are not any log files at all). This option is in POSIX, and > > has been used in t7407 for several years without anybody complaining. > > Also since c625bf0e (git-p4: git-p4 tests with p4 triggers, > 2017-07-13) t9831 has also been using it. It is not like a stray > error message about unmatched glob would really matter here, though. > We are not doing 2>&1 to let the downstream of the pipe see it, and > unless the test is run under "-v" option, it wouldn't even be seen. Yeah, I saw those. But I don't think they count since hardly anybody runs the p4 tests. They do run in CI, but on a rather limited set of platforms. Though come to think of it, this one would only kick in for LSan, which may also run on a pretty limited set of platforms. :) -Peff
