Patrick Steinhardt <ps@xxxxxx> writes: > On Fri, Jan 03, 2025 at 02:00:35PM +0100, Matteo Bagnolini wrote: >> From: matteobagnolini <matteobagnolini2003@xxxxxxxxx> This must match the author ident on the Signed-off-by: line. >> `test -f` and `! test -f` do not provide clear error messages when they fail. >> To enhance debuggability, use `test_path_is_file` and `test_path_is_missing`, >> which instead provide more informative error messages. >> >> Note that `! test -f` checks if a path is not a file, while >> `test_path_is_missing` verifies that a path does not exist. In this specific >> case the tests are meant to check the absence of the path, making >> `test_path_is_missing` a valid replacement. > > Thanks, this version looks good to me. > > Patrick Thanks for writing, and thanks for reviewing.
