When we run "git submodule", the script parses the various options and then invokes "git-submodule--helper". Unlike most builtin git commands which parse short/long options using parse-options.c, the parsing of arguments is completely done within git-submodule.sh; therefore, there are some inconsistencies with the rest of the commands, in particular the parsing of option arguments given to various options. Improve the handling of option arguments for both long & short options; for example, passing flags such as "--branch=master" or "-j8" now works. Changes since v1: - Make variable values always contain the option name. - Rename a couple of variables in order to improve consistency. Link to v1: https://lore.kernel.org/git/20241207135201.2536-1-royeldar0@xxxxxxxxx Roy Eldar (8): git-submodule.sh: make some variables boolean git-submodule.sh: improve parsing of some long options git-submodule.sh: improve parsing of short options git-submodule.sh: get rid of isnumber git-submodule.sh: get rid of unused variable git-submodule.sh: add some comments git-submodule.sh: improve variables readability git-submodule.sh: rename some variables git-submodule.sh | 214 +++++++++++++++++++++++------------------------ 1 file changed, 104 insertions(+), 110 deletions(-) -- 2.30.2
