Hi, Junio C Hamano <gitster@xxxxxxxxx> wrote: > As I said in the devil's advocate section in my review for 1/3, I > often find the value of the variable spelling out the option name > as well as the option value (i.e., force="--force", not force=1; > branch="--branch=foo", not branch=foo; jobs=--jobs=4, not jobs=4) > easier to debug and drive other programs using these variables, so I > do not mind jobs=--jobs=4 at all, but if we want to be consistent in > the other direction, this would probably want to be modified in the > name of consistency? I find this approach better as well, and I agree this is easier to read, and has some other advantages like better ability to debug the script. I modified the script so that all of the variables are assigned values which contain the option name as well as the option value, and I will post a v2 patch series soon. > Other than that, all three patches looked sane to me. Thanks a lot!
