Justin Tobler <jltobler@xxxxxxxxx> writes:
> +static int fetch_fsck_config_cb(const char *var, const char *value,
> + const struct config_context *ctx UNUSED, void *cb)
> +{
> + struct strbuf *msg_types = cb;
> + int ret;
> +
> + ret = fetch_pack_fsck_config(var, value, msg_types);
> + if (ret < 0)
> + return 0;
> +
> + return ret;
> +}
Looks good. Both callers of fetch_pack_fsck_config() must deal with
the unusual -1 return from it that signals "I didn't find what I
care", and the original caller does so by calling the default callback
while this one just says "everything is well".
I wasn't carefully looking for typoes and style violations, but the
logic flow in all these four patches looked perfect in this round.
Thanks for a pleasant read. Will queue.
