Greetings,
With 63d903ff52 (unbundle: extend object verification for fetches,
2024-06-19), fsck checks are now performed on fetched bundles depending
on `transfer.fsckObjects` and `fetch.fsckObjects` configuration. This
works, but provides no means to override the default fsck message
severity as is done for other git-fetch(1) operations. This series aims
to propagate fsck message severity configuration to the underlying
git-index-pack(1) process executed on the bundle in a similar manner as
done with git-fetch-pack(1).
- Patches 1 and 2 adapt the bundle subsystem to support additional
options when performing `unbundle()`.
- Patch 3 adapts the fetch-pack subsystem to expose a means to
generate the message configuration arguments.
- Patch 4 wires the newly generated fsck configuration options to the
bundle options used when fetching from a bundle.
Changes in V2:
- Reverted unnecessary line formatted changes.
- Simplified fallback logic for default `unbundle()` options.
- Dropped unncessary shell structure in the third patch to keep the
patch more straightforward.
- Instead of exposing `fetch_pack_config_cb()` directly, the fetch
pack fsck config parsing logic is split and exposed. This also
addresses the issue of unwanted default Git config parsing occuring.
Consequently the previous third and fourth patch were condensed into
a single patch.
- Improved explainations in the patches, naming, and various style
fixes.
Due to all rearranging in this version, I opted not to include a
range-diff.
Thanks
-Justin
Justin Tobler (4):
bundle: add bundle verification options type
bundle: support fsck message configuration
fetch-pack: split out fsck config parsing
transport: propagate fsck configuration during bundle fetch
builtin/bundle.c | 2 +-
bundle-uri.c | 7 +++++--
bundle.c | 13 +++++++++----
bundle.h | 17 ++++++++++++++---
fetch-pack.c | 24 +++++++++++++++++-------
fetch-pack.h | 3 +++
t/t5607-clone-bundle.sh | 7 +++++++
transport.c | 26 ++++++++++++++++++++++++--
8 files changed, 80 insertions(+), 19 deletions(-)
base-commit: 4083a6f05206077a50af7658bedc17a94c54607d
--
2.47.0
