On Wed, Nov 13, 2024, at 15:49, phillip.wood123@xxxxxxxxx wrote: > On 13/11/2024 01:03, Junio C Hamano wrote: >> kristofferhaugsbakk@xxxxxxxxxxxx writes: >> >>> From: Kristoffer Haugsbakk <code@xxxxxxxxxxxxxxx> >>> >> >> Describe what happens when a custom comment string is used without >> the fixed code in this space. > > It would also be helpful to explain how to trigger the bug [1] > > If I remember correctly it was Taylor who first noticed this [2]. If so > we should credit him with a "Reported-by:" trailer. > >>> Co-authored-by: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > It seems odd to me to have a "Co-authored-by:" trailer without a > corresponding "Signed-off-by:" If someone has contributed enough to > deserve "Co-authored-by:" then they should be signing off the code they > have contributed. In this case I'd be happy with "Helped-by:" instead > but feel free to add my "Signed-off-by:" if you want to keep > "Co-authored-by:". I’ll fix that in the next version. Thanks.
