RE: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> The `read_refs_snapshot` uses the `parse_oid_hex` function which 
>> internally uses global variables. Let's instead use
>
>Nit: s/variables/variable

No, that's fine.
It's plural, so ends with 's'.
Unless it should be "uses a global variable"

>>
>> Also, while here, fix a missing newline after the functions definition.
>>
>
>Nit: s/functions/function

Maybe.
But it could be "the function's definition" as it could be seen as possessive.

Regards,
Richard.







[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux