Re: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 19, 2024 at 04:36:42PM +0100, Karthik Nayak wrote:
> The `read_refs_snapshot` uses the `parse_oid_hex` function which
> internally uses global variables. Let's instead use

Nit: s/variables/variable

> `parse_oid_hex_algop` and provide the hash algo via `revs->repo`.
> 
> Also, while here, fix a missing newline after the functions definition.
> 

Nit: s/functions/function

> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx>




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux