Re: [PATCH] Fix rev-list when showing objects involving submodules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 12 Nov 2007, Linus Torvalds wrote:

> On Mon, 12 Nov 2007, Johannes Schindelin wrote:
> > 
> > You mean something like
> > 
> > 		else if (S_ISREG(entry.mod) || S_ISLNK(entry.mod))
> > 
> > Hmm?  Sure, I have no preference there.
> 
> Maybe more along the line of something like this?
> 
> In general, I suspect we should try to start moving away from using the 
> "S_ISLNK()" like things for internal git state. It was a mistake to just 
> assume the numbers all were same across all systems in the first place.
> 
> So this just converts to the "object_type", and then uses a case 
> statement.

Sure.  Just add the test from my patch, and we're fixed.

Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux